Open hh opened 6 months ago
Thanks for the suggestion, this is under evaluation. The primary concern is it could make it more complicated/cumbersome for all the non-Dvorak users, but if there is an easy way to do it and support it on an ongoing basis that could make sense.
@KinesisCorporation an easy way to achieve this, which doesn't require another branch or commit, would be to include other keyboard layouts in the config
folder of the repository in a separate keymap file. e.g. dvorak.keymap
, colemak.keymap
, colemak-dh.keymap
etc. while keeping the default qwerty in adv360.keymap
to avoid issues with existing forks.
For example if you added your Dvorak keymap as dvorak.keymap
then all users who wish to use that layout would have to do in their own repositories is update adv360_left.keymap
and adv360_right.keymap
to include the dvorak.keymap
instead of adv360.keymap
.
/*
*
* Copyright (c) 2021 Polarity Works
* SPDX-License-Identifier: MIT
*
*/
#include "dvorak.keymap"
This would allow you to publish alternative keymap layouts without breaking current user's repositories and at the same time offer alternative layouts for users with minimal effort to switch between them.
I have done this in my own repository to test and verify by moving my customized keymap into a personal.keymap
file and adjusted the includes in adv360_left.keymap
and adv360_right.keymap
.
It's worth noting doing so would break the online keymap configurator
Might be useful to update the key so editor to choose from a list of keymap files to edit. adv360, Mac, windows, and Dvorak among a few of the options.
On Sat, 2 Mar 2024 at 13:56, ReFil @.***> wrote:
It's worth noting doing so would break the online keymap configurator
— Reply to this email directly, view it on GitHub https://github.com/KinesisCorporation/Adv360-Pro-ZMK/issues/397#issuecomment-1974907016, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAHUY2NDYMZWGJWMS5CZVDYWI4INAVCNFSM6AAAAABECGFJFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZUHEYDOMBRGY . You are receiving this because you authored the thread.Message ID: @.***>
It's worth noting doing so would break the online keymap configurator
That's a good point to note. That seems more an issue of making sure there are clear instructions of how to use alternative layouts provided in a separate file.
Instead of updating the adv360_left.keymap
and adv360_right.keymap
users who wish to use the online editor can rename or delete the stock adv360.keymap
and rename the alternative layout keymap file to adv360.keymap
?
Or simply copy the full file content from one to the other file.
In my opinion a good way to accomplish this and benefit everyone is to have presets that you can load in the online config editor. It could be a button or a drop down with confirmation or similar. I just got a board and had to create my dvorak layout from scratch and I was surprised that I had to do it that way.
It seems the default factory image is here: https://kinesis-ergo.com/download/adv360-pro-factory-default-branch-3-0-v1-16-24-commit-ddcdb88/
And the factory Dvorak image is here: https://kinesis-ergo.com/download/adv360-pro-dvorak/
I'd like to have a branch or commit that includes the Pre-Programmed Dvorak layout. This would make an easier starting point for customization.