KinesisCorporation / Adv360-Pro-ZMK

Production repository for the all-new Advantage360 Professional using ZMK engine
MIT License
466 stars 6.68k forks source link

LEDs burning my eyes. #560

Closed adofse closed 1 month ago

adofse commented 2 months ago

As mentioned https://github.com/KinesisCorporation/Adv360-Pro-ZMK/issues/129, LEDs brightness intensity is too strong (100%?) in any lighting conditions which results in burning my eyes.

OFF ON
image image
See a video in https://github.com/KinesisCorporation/Adv360-Pro-ZMK/issues/129

To reproduce

I observed the following two patterns that LEDs shine 100%.

Expected Behaviour

User can change LED brightness intensity.

Ref

@KinesisCorporation suggested a guide in https://github.com/KinesisCorporation/Adv360-Pro-ZMK/issues/129#issuecomment-1494585400, but the instruction Edit line: CONFIG_ZMK_BACKLIGHT_BRT_SCALE=25 is for BACKLIGHTs not LEDs so It won't help.

ReFil commented 2 months ago

The short bright flash when the board powers up andd is in bootloader is unavoidable I'm afraid, it is an artifact of the bootloader and cannot be configured

adofse commented 2 months ago

@ReFil Does that mean you can't change that behavior in https://github.com/ReFil/zmk/tree/adv360-z3.5 or any other dependencies ?

[!warning] Seeing too bright lights could cause serious health harms for human eyes so it should be cared under Kinesis Corporation's responsibility.

adofse commented 2 months ago

Now we know how @KinesisCorporation treats their users since it's been 3 days when I report potential health harms issue.

I believe it's too early to take advantage open source ZMK for @KinesisCorporation as they claim they are small private company.

Highly Disappointed!

KinesisCorporation commented 2 months ago

Unfortunately this is not user-configurable.

Please contact Tech Support and link them to this discussion. We will accept a return of the keyboard.

https://kinesis-ergo.com/support/contact-a-technician/

adofse commented 1 month ago

@KinesisCorporation

Unfortunately this is not user-configurable.

Please elaborate this. Editing source code in https://github.com/ReFil/zmk/tree/adv360-z3.5 could solve this problem? If not, are you willing to contact someone who develop bootloader firmware?

KinesisCorporation commented 1 month ago

Hi,

The next time we do work on the bootloader we will explore whether the LEDs can be dimmed. If you decide to keep the keyboard we suggest not looking directly at the LEDs while opening the bootloader. We are still happy to process a return/exchange of the keyboard.

adofse commented 1 month ago

The next time we do work on the bootloader we will explore whether the LEDs can be dimmed.

@KinesisCorporation Could you assign @ReFil to take a look?