search

KinesisCorporation / Adv360-Pro-ZMK

Production repository for the all-new Advantage360 Professional using ZMK engine
MIT License
469 stars 6.71k forks source link

hold-trigger-key-positions do not work for homerow mods #596

Open szabop opened 1 week ago

szabop commented 1 week ago

I created the following configuration: https://github.com/KinesisCorporation/Adv360-Pro-ZMK/blob/e1fad2719ca14c0dc6b394e6b3cfcd36c77c492b/config/adv360.keymap

I am using the homerowmods to have easy access to modifiers. [motivation: Homerowmods paired with custom layouts for maxOS and Win enable me to type the special characters of my native language on the Kinesis 360 with relative ease]

When I type fast, letter combinations like l-i will register as Ctrl-i, which is a typing error on my side. However, this is such a common "user-error" that there is a fix for it in the ZMK firmware, the hold-trigger-key-positions feature. This should disable accidental modifier activation on the same hand when typing fast.

Unfortunately, this feature does not work on the firmware built for my Kinesis 360. It seems the settings on hold-trigger-key-positions are simply ignored.

KinesisCorporation commented 1 week ago

Hi! Congrats on your Adv360 Pro.

I suspect this feature hasn't been merged into the Adv360 branch.

@ReFil would know for sure.

szabop commented 3 days ago

Hi @ReFil ,

Could you please comment on the expected behaviour of the Kinesis 360 Pro firmware with regards to the hold-trigger-key-positions feature of ZMK?

Is the behaviour I experience a bug? Is this a configuration error on my side? Or is this something that will only come to the Kinesis firmware version at a later time? If it is the last option, what would be your rough estimate on the expected delivery (few weeks, few months or even never)?

Thanks and regards, Péter

ReFil commented 2 days ago

The ZMK branch used by the 360 was last updated approximately 6 months ago. hold-trigger-key-positions has been implemented since before then, I'm not aware if changes have been made to how the behaviour works since

ReFil commented 2 days ago

It sounds like you may be running into this issue https://github.com/zmkfirmware/zmk/issues/2040