search

KinesisCorporation / Adv360-Pro-ZMK

Production repository for the all-new Advantage360 Professional using ZMK engine
MIT License
470 stars 6.72k forks source link

Build action failed #8

Closed thinium closed 2 years ago

thinium commented 2 years ago

Hi! I just tried to build the ZMK firmware for the first time. But the action failed in two places. Is it possible there is an issue in the build script? How can I fix them?

Here is my build action: https://github.com/thinium/Adv360-Pro-ZMK/actions/runs/3061013510/jobs/4940248396#step:8:37

Screenshot 2022-09-16 at 09 18 20 Screenshot 2022-09-16 at 09 18 30

thinium commented 2 years ago

fixed.... it's caused by an empty biding

KinesisCorporation commented 2 years ago

Great!

dustMason commented 2 years ago

i'm having the same error - can you describe how you fixed it? i changed only a single key binding but am seeing this error on my github actions build

thinium commented 2 years ago

@dustMason in my case there is a macro that is empty (it contains no keys). After removing that macro everything works fine. Yours seems to be a different issue from mine. @KinesisCorporation it would be great to publish a list of typical mistakes and how to fix them. Also for newbies to build action how to debug it. The ZMK people told me that your version has diverged a lot from theirs (it seems that yours is based on a rather old version), and they might not be able to provide much help in the future.

dustMason commented 2 years ago

Thank you – it turns out that my error was also caused by an empty macro. I rolled back my changes one by one until i discovered the empty macro. It's easy to make this mistake in the GUI editor – I suggest adding a validation in the editor to prevent saving an empty macro.

KinesisCorporation commented 2 years ago

Appreciate all the dialogue guys!

  1. We're about to publish an update that merges our custom features with the latest from ZMK.
  2. And we're starting a troubleshooting tip with a list of common mistakes here: https://kinesis-ergo.com/support/kb360pro/#troubleshooting