search

Kintyre / shinnecock-agent

Standalone client for Kintyre Speed Testing
2 stars 0 forks source link

speedtest only default interface #19

Closed ljonsson closed 6 years ago

ljonsson commented 6 years ago

Run speedtest on ifcfg.default_route() instead of on all interfaces reported by ifcfg.interfaces()

codecov[bot] commented 6 years ago

Codecov Report

Merging #19 into master will increase coverage by 0.76%. The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   78.42%   79.18%   +0.76%     
==========================================
  Files           1        1              
  Lines         190      197       +7     
==========================================
+ Hits          149      156       +7     
  Misses         41       41
Impacted Files Coverage Δ
kintyre_speedtest.py 79.18% <95.23%> (+0.76%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aaae5d4...8dcb867. Read the comment docs.

lowell80 commented 6 years ago

Rejecting this change because I don't want to loose the ability to test multiple interfaces. I've introduced CLI options that allow the user to (1) pick which interface(s) to test against explicitly, and (2) allow the user to pick the default gateway, a random interface, or ALL interfaces if they so desire.

This is resolved as of release v0.3.3 (1c4eccca8355565)