KitwareMedical / tensorboard-plugin-3d

https://tensorboardplugin3d.readthedocs.io/en/latest/
33 stars 4 forks source link

feat(toggle data): Add ability to toggle current data #42

Closed bnmajor closed 2 years ago

bnmajor commented 2 years ago

Support the ability to toggle between all of the images available in the logdir.

This branch provides some changes that work around existing bugs that prevent simply updating the image/label in the viewer. Instead the viewer object is re-instantiated each time that the data is toggled and the state from the previous data is saved and re-applied to the next image and/or label.

Relies on changes in InsightSoftwareConsortium/itk-viewer-material-ui#17

https://user-images.githubusercontent.com/51238406/153461775-2ea2df00-f237-46f0-9ab3-d4a55f3064fa.mp4

bnmajor commented 2 years ago

@thewtex @aylward

This branch is almost ready to go, I've reached out to Matt about a new concern I have but other than that just need some input on the final decision for layout/appearances. We have (at least) four options for the toggle arrows: arrow_options

  1. Default MUI buttons
  2. Default MUI buttons with styling more consistent with other components
  3. Moving the buttons with the input under the layer widgets (styling can be changed of course)
  4. Moving buttons and input to the very bottom (again, styling has options)

We can also choose to either set the arrows to default to disabled rather than hidden if that would be better: disabled_arrows hide_arrows

aylward commented 2 years ago

Hi,

I like it!

My favorite is

BUT - since image number is a higher level concept/organization than layer, is it easy to move the button and input to the line above the layer widget?

s

On Mon, Feb 14, 2022 at 11:03 AM Brianna Major @.***> wrote:

@thewtex https://github.com/thewtex @aylward https://github.com/aylward

This branch is almost ready to go, I've reached out to Matt about a new concern I have but other than that just need some input on the final decision for layout/appearances. We have (at least) four options for the toggle arrows: [image: arrow_options] https://user-images.githubusercontent.com/51238406/153894578-48b502a1-a67e-481a-a097-6690151162ea.png

  1. Default MUI buttons
  2. Default MUI buttons with styling more consistent with other components
  3. Moving the buttons with the input under the layer widgets (styling can be changed of course)
  4. Moving buttons and input to the very bottom (again, styling has options)

We can also choose to either set the arrows to default to disabled rather than hidden if that would be better: [image: disabled_arrows] https://user-images.githubusercontent.com/51238406/153895336-91483896-9c30-48ef-8111-dcce37d17036.gif [image: hide_arrows] https://user-images.githubusercontent.com/51238406/153895335-871bf1f0-41ff-437a-b212-ff0868eed1cd.gif

— Reply to this email directly, view it on GitHub https://github.com/KitwareMedical/tensorboard-plugin-3d/pull/42#issuecomment-1039234154, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACEJL7SIVG5ULBQ7BDVF6DU3EOX3ANCNFSM5OBGM24Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- Stephen R. Aylward, Ph.D. Senior Director of Strategic Initiatives

Kitware: Delivering innovation.

bnmajor commented 2 years ago

Hi, I like it! My favorite is * Moving the buttons with the input under the layer widgets (styling can be changed of course) BUT - since image number is a higher level concept/organization than layer, is it easy to move the button and input to the line above the layer widget? s

Yes, here it is above the layer widget: hidden_arrows

I've added a small progress bar as well because I found that the re-load is slow sometimes and it isn't clear if anything is happening.