Closed bnmajor closed 2 years ago
Thanks for the tips @thewtex! I have been working on this some more using your suggestions but I am currently stuck on the following error:
ERROR in ./node_modules/itk-vtk-viewer/src/ViewerStore.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
SyntaxError: /home/local/KHQ/brianna.major/tensorboard-plugin-3d/client/node_modules/itk-vtk-viewer/src/ViewerStore.js: Support for the experimental syntax 'decorators-legacy' isn't currently enabled (23:3):
21 | class MainUIStore {
22 | uiContainer = null
> 23 | @observable collapsed = false
| ^
24 | @observable annotationsEnabled = true
25 | @observable axesEnabled = false
26 | @observable fullscreenEnabled = false
I've pushed a WIP commit with the most recent changes in case there is something obvious that you can see that I am doing wrong, in the meantime I'll keep looking into what's going on and reading up on webpack rules to try and understand what I'm missing.
@observable
@bnmajor I believe this is addressed by enabling the mobx
babel preset:
https://github.com/Kitware/itk-vtk-viewer/blob/e0b5bffc8cd499b9f8ac310ba2b1fe7ee3309a9b/.babelrc#L9
@observable
@bnmajor I believe this is addressed by enabling the
mobx
babel preset:https://github.com/Kitware/itk-vtk-viewer/blob/e0b5bffc8cd499b9f8ac310ba2b1fe7ee3309a9b/.babelrc#L9
Thanks @thewtex! I did try this but still have the error, unfortunately.
@bnmajor is babel-preset-mobx
installed?
Or is a different babel config being picked up?
@bnmajor is
babel-preset-mobx
installed?Or is a different babel config being picked up?
@thewtex Thank you for pointing this out, I had babel-preset-mobx
installed but it was missing from the webpack list of presets. The last change that I was missing was to rename the babel config from .babelrc
to babel.config.json
in order to apply the configuration to the entire project. Thank you for all of your help, I believe this is ready for review now!
Bundle the itk-vtk-viewer with the python package
WIP: Relies on Kitware/itk-vtk-viewer#475. Will need to update viewer version once that PR is in.
Fixes #53