Knowledge-Graph-Hub / kg-microbe

https://knowledge-graph-hub.github.io/kg-microbe/index.html
BSD 3-Clause "New" or "Revised" License
17 stars 3 forks source link

A few BactoTraits columns that are missing #252

Open realmarcin opened 2 months ago

realmarcin commented 2 months ago

These were omitted earlier for sake of time -- but they do provide new features which are sizes of the ranges. I am modeling these in the ontology and will have these column names as xrefs. If its not much work, it would be good to ingest this for completness.

pHd_<=1 pHd_1_2 pHd_2_3 pHd_3_4 pHd_4_5 pHd_5_9

Nad_<=1 Nad_1_3 Nad_38 Nad>8

Td_1_5 Td_5_10 Td_10_20 Td_2030 Td>30

Definitions are here: https://www.sciencedirect.com/science/article/pii/S1470160X21007123

pH_delta Extend of pH units that a strain can grow (calculated from pH_Range trait: max–min value) pH unit Quantitative, categorial 6 categories (<1, ≥1-2, ≥2-3, ≥3-4, ≥4-5, ≥5-9) 1
Temp_delta Extend of the temperature range in which a strain can grow (calculated from temp_Range trait) °C Quantitative, categorial 5 categories (≥1-5, ≥5-10, ≥10-20, ≥20-30, ≥30) 1
Temp_delta Extend of the temperature range in which a strain can grow (calculated from temp_Range trait) °C Quantitative, categorial 5 categories (≥1-5, ≥5-10, ≥10-20, ≥20-30, ≥30) 1

@hrshdhgd

hrshdhgd commented 2 months ago

pH_delta prefixes are already in the KG:

https://github.com/Knowledge-Graph-Hub/kg-microbe/blob/9b8343a5200579e10cfc1703176181d7a302755f/data/transformed/BactoTraits/nodes.tsv#L52-L60

For the other two is there data for them at all? I see just 0 or None values.

All the prefixes in the custom_curies.yaml have been considered during the KG creation.

realmarcin commented 2 months ago

OK thanks for checking! Yes, if there are no values then nothing to ingest of course! These are all now in the ontology as well.

Of course I should have checked the merge first! These are already ingested, so there were some real values available for all three types of delta terms:

grep temp_delta: merged-kg_edges.tsv | wc 3951 27657 538151 grep pH_delta: merged-kg_edges.tsv | wc 2915 20405 391781 grep NaCl_delta: merged-kg_edges.tsv | wc 3123 21861 424900