search

KrishnaswamyLab / MAGIC

MAGIC (Markov Affinity-based Graph Imputation of Cells), is a method for imputing missing values restoring structure of large biological datasets.
GNU General Public License v2.0
341 stars 97 forks source link

scprep==0.10.0 #149

Closed Dangertrip closed 5 years ago

Dangertrip commented 5 years ago

Have to install scprep==0.10.0 when using MAGIC in python3.6 Higher version of scperp doesn't work for MAGIC. Plz notice and change the requirement~

scottgigante commented 5 years ago

Hi @Dangertrip , can you please explain what doesn't work about higher versions of scprep with MAGIC?

Dangertrip commented 5 years ago

I use pip to install scprep in python3.6 But when I run "import magic", error was reported. I reinstalled scprep==0.10.0 and no error appears again. I'm using Mac here. Here's my error: Traceback (most recent call last): File "", line 1, in File "/Users/yyin/.local/lib/python3.6/site-packages/magic/init.py", line 3, in from .magic import MAGIC File "/Users/yyin/.local/lib/python3.6/site-packages/magic/magic.py", line 22, in import scprep File "/Users/yyin/.local/lib/python3.6/site-packages/scprep/init.py", line 5, in import scprep.io File "/Users/yyin/.local/lib/python3.6/site-packages/scprep/io/init.py", line 6, in from .fcs import load_fcs File "/Users/yyin/.local/lib/python3.6/site-packages/scprep/io/fcs.py", line 225, in @utils._with_pkg("fcsparser") File "", line 2, in _with_pkg File "/Users/yyin/anaconda3/lib/python3.6/site-packages/decorator.py", line 228, in decorate evaldict, wrapped=func) File "/Users/yyin/anaconda3/lib/python3.6/site-packages/decorator.py", line 208, in create name, rest = obj.strip().split('(', 1) ValueError: not enough values to unpack (expected 2, got 1)

scottgigante commented 5 years ago

This is an issue with scprep, moving the conversation over there.

scottgigante commented 5 years ago

@Dangertrip just to be clear, I have reopened this issue at https://github.com/KrishnaswamyLab/scprep/issues/33

scottgigante commented 5 years ago

@Dangertrip should be all fixed now. pip install --upgrade magic-impute will have you all set.

Dangertrip commented 5 years ago

Sorry about the delay. I just came back in town today. Thank you for solving this problem!