search

KrishnaswamyLab / MAGIC

MAGIC (Markov Affinity-based Graph Imputation of Cells), is a method for imputing missing values restoring structure of large biological datasets.
GNU General Public License v2.0
334 stars 97 forks source link

Name of the package confused with python-magic package #218

Open Rohit-Satyam opened 1 year ago

Rohit-Satyam commented 1 year ago

Describe the bug

AttributeError                            Traceback (most recent call last)
Cell In[37], line 4
      1 import magic
      3 # Apply MAGIC for PCA data denoising
----> 4 magic_op = magic.MAGIC(random_state=random_seed, solver='approximate', n_pca=n_comps)
      5 X_magic = magic_op.fit_transform(data.X, genes='pca_only')
      6 data.obsm['X_magic_pca'] = X_magic

AttributeError: module 'magic' has no attribute 'MAGIC'

The error module 'magic' has no attribute 'MAGIC' is due to the fact that magic-impute is imported as magic and also python-magic is also imported in a similar fashion. I thought uninstalling python-magic would fix the issue but the issue persists. Can you improve the naming so that it does not conflict with the magic package for images?