search

Kryeit / Missions

Create mod addon that brings weekly missions [Forge/Fabric] (1.18/1.19/1.20)
MIT License
5 stars 7 forks source link

Option to disable some missions #21

Closed Proxwian closed 7 months ago

Proxwian commented 7 months ago

Describe the Suggestion

Maybe its already possible, but when I'm trying to delete a mission category (ride, for example), game does not launch at all.

Can you please add possibility to remove some missions categories from config file? Thanks.

Screenshots and Videos

No response

Additional Context

No response

muriplz commented 7 months ago

it has been possible since the first version of the mod. See the modrinth/curseforge page for info. If that's too much words: just delete the ride mission from missions.json IN THE SERVER FILES

Proxwian commented 7 months ago

OK, but what 'bout singleplayer? I want to remove some missions for my modpack

muriplz commented 7 months ago

for that too, just remove the ride mission in missions.json haha

Proxwian commented 7 months ago

But client is crashing when I try to launch with deleted category

muriplz commented 7 months ago

I see, i'll test this, can you please tell me forge/fabric, missions version and minecraft version

Proxwian commented 7 months ago

Forge 47.2.20, missions-forge-0.2.12.jar, Minecraft 1.20.1

muriplz commented 7 months ago

Thanks, will try to fix this this week

MrRedRhino commented 7 months ago

Is this issue still not solved?

muriplz commented 7 months ago

I havent been able to replicate. For this, server owners have to upload the modpack with a config/missions/missions.json. Or else singleplayers will have the default missions

Proxwian commented 7 months ago

I'm still not able to delete some mission categories from singleplayer

muriplz commented 7 months ago

then provide version and loader, and mc version, i've tested all 6 version on latest and no issue, but it's hard to test 6 things each time an issue occurs

muriplz commented 7 months ago

nvm im dumb didnt read the whole converstaion image But it's your issue, not ours.

  1. you are not resetting mods/missions/ folder, since you probably have the missions created from the last missions.json
  2. your missions.json is fine
muriplz commented 7 months ago

basically, reset your missions_data.nbt. Create: Missions cannot realize when you want it reseted on its own, so whenever you make changes to missions.json you need to reset mods/missions/missions_data.json

muriplz commented 7 months ago

the modpack actually would have worked, except for you, since you already joined with the previous missions.json, therefore the missions_data.nbt has your uuid with 10 missions, which are from the old missions.json, not the new one

Proxwian commented 7 months ago

OK, I would try it