search

KunstmaanLegacy / KunstmaanAdminNodeBundle

THIS REPO IS DEPRECATED: see KunstmaanNodeBundle. The KunstmaanAdminNodeBundle for Symfony 2 is part of the bundles we use to build custom and flexible applications at Kunstmaan. You have to install this bundle in order to work with nodes and pagetypes.
http://kunstmaan.github.com/KunstmaanAdminNodeBundle
MIT License
2 stars 0 forks source link

possibility to add extra sub actions on top of the page #93

Closed daanporon closed 12 years ago

daanporon commented 12 years ago

Possibility to add extra sub actions on top of the page. For now we'll use this to show a link to the form submissions on top of the page. See https://github.com/Kunstmaan/KunstmaanFormBundle/pull/32

travisbot commented 12 years ago

This pull request passes (merged 703e0d18 into 2ca89b52).

daanporon commented 12 years ago

Are we going to do it this way by specifying a template to add custom actions .. or should we configure the actions in code, so that we get an array of all the actions and we can update them ... I think this way gives us much more flexibility, the only problem is we can only add other actions at the end. Anyone who prefers the other way or would use another way?

kimausloos commented 12 years ago

We could also give a weight so you can control the actions a bit, so when you add an action with weight -1 it should be the first action.

daanporon commented 12 years ago

yes, but then we should move to configuring it in code in stead of with templates

daanporon commented 12 years ago

this needs to be done using template helpers etc. first we need to check how knpMenuBundle does this things ...

roderik commented 12 years ago

This needs to go higher on the priorities list.

daanporon commented 12 years ago

i refactored this into using knpMenu, still needs some more testing. I also want to check if the folder structure is correct. Maybe we need to make some guidlines in how the folder structure will work in the Kunstmaan Bundles. Also the items need to be translatable

roderik commented 12 years ago

Je moet wel unit tests toevoegen. Elke methode moet je op zijn minst "aanroepen" in de test zodat we weten of het nog werkt als we iets veranderen. Bv typing ergens ooit.

roderik commented 12 years ago

btw, er is een skeleton generator, kom even vragen