Why to remove query masking?

Kyubyong / transformer

A TensorFlow Implementation of the Transformer: Attention Is All You Need

Apache License 2.0

4.28k stars 1.3k forks source link

Why to remove query masking? #162

Closed ywl0911 closed 4 years ago

ywl0911 commented 4 years ago

hello all. I am new hear. I found the query masking is removed in the latest version, but the key masked is still retained. Cloud someone tell me the reason why removing the query msking? Or the query masking work is finished in the other place? Thanks!