LCR-BCCRC / lcr-modules

Collection of standard analytical pipelines for genomic and transcriptomic data
https://lcr-modules.rtfd.io
MIT License
15 stars 7 forks source link

ichorCNA 1.1 update patch #284

Open Jwong684 opened 10 months ago

Jwong684 commented 10 months ago

Updated ichorcna to allow for more flexibility in reference wigs (though ended up being a moot change for grch37-noalt); updated reference workflow to include hg19-reddy_masked.

Note that chrY info is needed for ichorCNA to complete. In the case of grch37-noalt (with no chrY), added extra lines in the wig to denote 0 coverage for chrY.

Pull Request Checklists

Important: When opening a pull request, keep only the applicable checklist and delete all other sections.

Checklist for New Module

Required

If applicable

Checklist for Updated Module

Important! If you are updating the module version, ensure the previous version of the module is restored from master. If you want to restore a deleted file or directory from the remote master, you can use git checkout origin/master path/to/file, then a git commit will ensure that file is tracked on your branch again. Example:

mv modules/strelka/1.1 modules/strelka/1.2
git checkout origin/master modules/strelka/1.1
Kdreval commented 6 months ago

@Jwong684 just checking if you have any updates for Laura's comments?

Jwong684 commented 5 months ago

Added requested documentation and a guide to creating a custom panel of normals - should be good now

Kdreval commented 1 month ago

@lkhilton it doesn't let me merge this because of the requested changes - can you please approve if everything is OK so we can get this to master?