LDMX-Software / ldmx-sw

The Light Dark Matter eXperiment simulation and reconstruction framework.
https://ldmx-software.github.io
GNU General Public License v3.0
22 stars 20 forks source link

Hcal geometry condition updates + refactoring #1117

Closed EinarElen closed 1 year ago

EinarElen commented 1 year ago

Given the new and more complicated hcal geometry, there are more things we want to be able to ask the geometry condition. I want to take the opportunity when adding these to also try and clean things up in there a bit. @ehrlich-uva feel free to suggest other things you might need below

EinarElen commented 1 year ago

For the scintillator bar orientation, I'm thinking maybe we can get away with not handling that yet. Currently, only the v14 geometry has a side-hcal which is relevant for Ralf's scintillation simulation so... We can survive with handling it there

ehrlich-uva commented 1 year ago

Is there a function that returns the version number of the geometry? If so, we can use some if/thens to use the older HcalDigitization methods for older geometry versions.

EinarElen commented 1 year ago

There isn't currently, but i still think it would be valuable to have two distinct digiproducers and in that case we maybe wouldn't need it

ehrlich-uva commented 1 year ago

Yes, we can keep both digiproducers.