Open bryngemark opened 1 year ago
@bryngemark this is not an issue anymore for 8 GeV, right? If I look at the gold for the inclusive
https://github.com/LDMX-Software/ldmx-sw/blob/trunk/.github/validation_samples/inclusive/gold.root
it shows the RoC variables, and also it fills the fiducial
variable, which is based on the recoil electrons position/momentum. Based on that I'd say this issue can be closed.
Describe the bug I don't see the recoil electron position or momentum info, nor the containment radius variables being filled, in an inclusive sample generated with release v3.2.10
To Reproduce Steps to reproduce the behavior:
/sdf/group/ldmx/data/user.lenekrist/v14/4.0GeV/v3.2.10_1e_pencilBeam/
Desired behavior I thought we hade fixed this, at least we did for signal, see https://github.com/LDMX-Software/ldmx-sw/issues/1153 I'd like the electron recoil info to be available for any process, in a way that matches our intuition that the recoil electron is the "same" particle as the incoming electron, after it has passed the target/undergone some significant interaction, whichever happens first.
I also think this highlights that there is something missing in our validation suite. Perhaps this will be amended in the procedure to do 8 GeV validation that will come. I think having a predefined set of histograms for each type of sample, and a corresponding gold, would be a very powerful way to efficiently pinpoint any basic problems in our simulation and do much of the heavy lifting in sample validation.
Environment: I used the v3.2.10 production image on LDCS for this.
Additional context