Nonfiducial filter for ECAL pn

tvami commented 1 month ago

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This work was done years ago at UCSB (by David Jiang). Given that we'd like to get rid of stale branches I rebased this and cleaned it a bit. I'm opening the PR more of a discussion if this is still useful.

As for testing I ran Biasing/test/ecal_pn_nonfiducial.py looks all good, and produces less events than the equivalent Biasing/test/ecal_pn.py which makes me thing that all the events are non-fiducial

Check List

[x] I successfully compiled ldmx-sw with my developments
[x] I ran my developments and the following shows that they are successful.
[x] I attached any sub-module related changes to this PR.

Related Sub-Module PRs

https://github.com/LDMX-Software/SimCore/pull/117

tvami commented 1 month ago

I'll do the cleanup mentioned in https://github.com/LDMX-Software/ldmx-sw/pull/1285#discussion_r1569389393 and also compare how moving from old_ecal to ecal changes.

But generally, @tomeichlersmith do you agree that this PR adds something useful to ldmx-sw, or somehow since this branch was opened there are better ways to achieve the same thing?

tomeichlersmith commented 1 month ago

Yea I think this is useful, I could definitely imagine someone wanting to generate a similar sample and this is the only way currently I know of to do that.

tvami commented 1 month ago

@tomeichlersmith I think you'll have to do the merge trunk method again :/ following

git switch trunk
git pull
git switch -
git rebase trunk

resulted in a conflict

LDMX-Software / ldmx-sw