The CMake configuration of the parent Python module originated from a time when we were expecting the more stable modules (like Framework and SimCore) to be adopted by other experiments and thus the parent python module might change to something other than LDMX. Now, it is just clutter that we can undo in order to avoid further confusion down the road.
and drop its usage in all the submodule CMakeLists.txt.
This then means we can change the .py.in Python files into .py by replacing @PYTHON_PACKAGE_NAME@ with LDMX and update the following to just look for .py and use the COPY_ONLY option of configure_file.
The CMake configuration of the parent Python module originated from a time when we were expecting the more stable modules (like Framework and SimCore) to be adopted by other experiments and thus the parent python module might change to something other than
LDMX. Now, it is just clutter that we can undo in order to avoid further confusion down the road.We can remove
https://github.com/LDMX-Software/ldmx-sw/blob/11d6a8e89250b357885602075c88b423dc04cdeb/CMakeLists.txt#L43-L44
and drop its usage in all the submodule
CMakeLists.txt.This then means we can change the
.py.inPython files into.pyby replacing@PYTHON_PACKAGE_NAME@withLDMXand update the following to just look for.pyand use theCOPY_ONLYoption ofconfigure_file.https://github.com/LDMX-Software/ldmx-sw/blob/11d6a8e89250b357885602075c88b423dc04cdeb/cmake/BuildMacros.cmake#L168-L205