LDMX-Software / ldmx-sw

The Light Dark Matter eXperiment simulation and reconstruction framework.
https://ldmx-software.github.io
GNU General Public License v3.0
22 stars 21 forks source link

Double check secondary corrections for 8 GeV in ECAL digi #1419

Open tvami opened 3 months ago

tvami commented 3 months ago

Is your feature request related to a problem? Please describe.

I was just talking with Tom regarding these numbers https://github.com/LDMX-Software/ldmx-sw/blob/trunk/Ecal/python/digi.py#L207 seem to be specific for 4 GeV.

Describe the solution you'd like

Just check if the numbers are very different for 8 GeV or not. I understand from Tom that the way these were calculated is simply to shoot an 8 GeV electron gun into the ECAL (from (0,0,240) with zero angle) and fit a double-sided Gaussian

Describe alternatives you've considered

It's second order effect, probably not too high of a priority

tvami commented 2 months ago

@anandaguha can you please look into this? You are running guns anyway

anandaguha commented 2 months ago

I am just not 100% sure about what distribution I will be fitting the double sided Gaussian to, but everything else seems pretty simple for me to do.

tvami commented 2 months ago

sure about what distribution I will be fitting

that ok, let's chat about it!