Biasing state and configuration should be made non-static

LDMX-Software / ldmx-sw

The Light Dark Matter eXperiment simulation and reconstruction framework.

https://ldmx-software.github.io

GNU General Public License v3.0

21 stars 19 forks source link

Biasing state and configuration should be made non-static #258

Closed JeremyMcCormick closed 4 years ago

JeremyMcCormick commented 7 years ago

Currently the state of the biasing system is managed via static variables, especially in BiasingMessenger. This is problematic because it will prevent the sim code from eventually being MT compatible. It also means (I think) that some biasing procedures can only be activated one at a time by process and particle type and not simultaneously. It should be possible to activate multiple biasing procedures for the same run.

tomeichlersmith commented 4 years ago

I believe PR #651 solved this issue.

omar-moreno commented 4 years ago

Yes, this should be closed.

On Thu, Mar 26, 2020, 12:27 PM Tom Eichlersmith notifications@github.com wrote:

I believe PR #651 https://github.com/LDMX-Software/ldmx-sw/pull/651 solved this issue.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/LDMX-Software/ldmx-sw/issues/258#issuecomment-604637195, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4JMXDLTAYVKTNFRUZDJBDRJOUC7ANCNFSM4DGTIQQQ .