search

LDMX-Software / ldmx-sw

The Light Dark Matter eXperiment simulation and reconstruction framework.
https://ldmx-software.github.io
GNU General Public License v3.0
22 stars 20 forks source link

Clean up compilation warnings #791

Closed omar-moreno closed 4 years ago

tomeichlersmith commented 4 years ago

@omar-moreno I have a small number of compilation warning patches on the iss617 branch, but I didn't attempt to fix the warnings being generated by our dependencies.

tomeichlersmith commented 4 years ago

I just did a clean build of the master branch and I saw zero compilation warnings! Something in your cmake updates must have made cmake smart enough to ignore the warnings from our dependencies.

omar-moreno commented 4 years ago

It's the power of modern cmake :)

On Thu, Sep 17, 2020 at 9:00 AM Tom Eichlersmith notifications@github.com wrote:

I just did a clean build of the master branch and I saw zero compilation warnings! Something in your cmake updates must have made cmake smart enough to ignore the warnings from our dependencies.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LDMX-Software/ldmx-sw/issues/791#issuecomment-694331619, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4JMXGJVHLWYH6D6ACDSQLSGIXA7ANCNFSM4NPSBFLQ .