Allow for Signal.signal choices to be configured

LPgenerator / django-db-mailer

Django module to easily send emails/sms/tts/push using django templates stored on database and managed through the Django Admin

https://github.com/LPgenerator/django-db-mailer

GNU General Public License v2.0

255 stars 81 forks source link

Allow for Signal.signal choices to be configured #102

Open kaleb opened 6 years ago

kaleb commented 6 years ago

This adds a DB_MAILER_SIGNAL_CHOICES setting. It also changes signal values from expecting to be a name for a member in the module django.db.models.signals and now expects a full path to a signal. This allows user to specify other signals that they may choose to define. The migrations will rename all records in the database that uses the previous naming convention.

Before to submit your pull-request:

Be sure that the unit tests pass
If you create a new feature, test your code, do not introduce new bugs
Avoid code duplication
Small pull-requests are easier to review and can be merged quickly
1 pull-request == 1 feature/improvement

kaleb commented 6 years ago

It looks like travis passed 11 out of 12 of the tests. Failed on the python3.5 with DJANGO=1.9.12 build when trying to pip install requests.

ruscoder commented 6 years ago

Hello @kaleb! What problems do this PR resolves? Why do you need it?

kaleb commented 6 years ago

I have some custom signals that I would like to use.

On Wed, Sep 5, 2018, 3:44 AM Vadim Laletin notifications@github.com wrote:

Hello @kaleb https://github.com/kaleb! What problems do this PR resolves? Why do you need it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LPgenerator/django-db-mailer/pull/102#issuecomment-418632185, or mute the thread https://github.com/notifications/unsubscribe-auth/AAekZJwp0h3U0msTs4NZXgry8skGIIkqks5uX4DTgaJpZM4RhWvr .