search

LPgenerator / django-db-mailer

Django module to easily send emails/sms/tts/push using django templates stored on database and managed through the Django Admin
https://github.com/LPgenerator/django-db-mailer
GNU General Public License v2.0
256 stars 80 forks source link

__init__() got an unexpected keyword argument 'queue' #78

Closed sagarg1988 closed 7 years ago

sagarg1988 commented 7 years ago

Unable to send mail when using signals.

I am using django-db-mailer 2.3.13 with Django 1.8.2. After setting the post_save signal for a model and updating the object through the Django Admin, I get this error when I save the model and expect an email to be sent.

__init__() got an unexpected keyword argument 'queue'

in

/dbmail/backends/mail.py in _send_html_message, line 167

Here's the traceback:

Environment:

Request Method: POST
Request URL: http://127.0.0.1:8000/admin/api_v1/paymentgatewayresponse/600/

Django Version: 1.8.2
Python Version: 2.7.10
Installed Applications:
('grappelli',
 'django.contrib.admin',
 'django.contrib.sites',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'simple',
 'rest_framework',
 'rest_framework.authtoken',
 'rest_auth',
 'ajaximage',
 'vote',
 'django_extensions',
 'audit_log',
 'tinymce',
 'taggit',
 'taggit_autosuggest',
 'crispy_forms',
 'rest_framework_swagger',
 'import_export',
 'django_bitly',
 'expirables',
 'totalsum',
 'hvad',
 'user_media',
 'generic_positions',
 'dbmail',
 'quickbooks',
 'rest_framework_docs',
 'storages',
 'push_notifications',
 'oauth2_provider',
 'social.apps.django_app.default',
 'rest_framework_social_oauth2',
 'api_v1',
 'content_display',
 'review')
Installed Middleware:
('django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware',
 'django.contrib.auth.middleware.SessionAuthenticationMiddleware',
 'audit_log.middleware.UserLoggingMiddleware')

Traceback:
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/django/core/handlers/base.py" in get_response
  132.                     response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/django/contrib/admin/options.py" in wrapper
  616.                 return self.admin_site.admin_view(view)(*args, **kwargs)
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/django/utils/decorators.py" in _wrapped_view
  110.                     response = view_func(request, *args, **kwargs)
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/django/views/decorators/cache.py" in _wrapped_view_func
  57.         response = view_func(request, *args, **kwargs)
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/django/contrib/admin/sites.py" in inner
  233.             return view(request, *args, **kwargs)
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/django/contrib/admin/options.py" in change_view
  1519.         return self.changeform_view(request, object_id, form_url, extra_context)
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/django/utils/decorators.py" in _wrapper
  34.             return bound_func(*args, **kwargs)
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/django/utils/decorators.py" in _wrapped_view
  110.                     response = view_func(request, *args, **kwargs)
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/django/utils/decorators.py" in bound_func
  30.                 return func.__get__(self, type(self))(*args2, **kwargs2)
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/django/utils/decorators.py" in inner
  145.                     return func(*args, **kwargs)
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/django/contrib/admin/options.py" in changeform_view
  1467.                 self.save_model(request, new_object, form, not add)
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/django/contrib/admin/options.py" in save_model
  1078.         obj.save()
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/django/db/models/base.py" in save
  710.                        force_update=force_update, update_fields=update_fields)
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/django/db/models/base.py" in save_base
  734.                                   update_fields=update_fields)
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/django/dispatch/dispatcher.py" in send
  201.             response = receiver(signal=self, sender=sender, **named)
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/dbmail/signals.py" in signal_receiver
  158.         SignalReceiver(sender, **kwargs).run()
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/dbmail/signals.py" in run
  131.             self._run()
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/dbmail/signals.py" in _run
  127.             self.send_mail()
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/dbmail/signals.py" in send_mail
  96.                         **self.get_interval()
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/dbmail/__init__.py" in send_db_mail

File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/dbmail/__init__.py" in db_sender

File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/dbmail/backends/mail.py" in send
  281.             try:
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/dbmail/backends/mail.py" in _try_to_send
  264.         for self._num in range(1, self._template.num_of_retries + 1):
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/dbmail/backends/mail.py" in _send
  249.         if self._provider is not None:
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/dbmail/backends/mail.py" in _send_by_native_provider
  243.     def _send_by_native_provider(self):
File "/Users/wayneb/myvirtualenv/lib/python2.7/site-packages/dbmail/backends/mail.py" in _send_html_message
  167.             self._subject, clean_html(self._message), cc=self._cc,

Exception Type: TypeError at /admin/api_v1/paymentgatewayresponse/600/
Exception Value: __init__() got an unexpected keyword argument 'queue'

I notice that I am not getting this error when I send the mail without using signals, i.e. by directly calling db_mail.

In that case, I can send successfully by calling dbmail.send_db_mail(mail_template, recipient_email, mail_context_vars).

I am not using Celery, and am sending the mail through SMTP.

gotlium commented 7 years ago

Hi, can you try fix this issue by following code

    # dbmail/backends/mail.py:Sender, line 263
    def _try_to_send(self):
        self._kwargs.pop('queue', None)
        ...