search

LPgenerator / django-db-mailer

Django module to easily send emails/sms/tts/push using django templates stored on database and managed through the Django Admin
https://github.com/LPgenerator/django-db-mailer
GNU General Public License v2.0
256 stars 80 forks source link

https in trackable url #97

Open lcd1232 opened 7 years ago

lcd1232 commented 7 years ago

Right now if you're using https on server you still get url with http, there is no checking about protocol. Problem is here

gotlium commented 7 years ago

I think we can add new constant to fix this problem.

lcd1232 commented 7 years ago

@gotlium I think better provide argument like is_secure or the whole request object to def send_db_mail(*args, **kwargs) because one django server can serve many sites and some of them can using http and others https. The best way to know is https or not using check request.is_secure()

gotlium commented 7 years ago

By default we can use is_secure=False, and when required https, developer can add is_secure=request.is_secure(). PR?

lcd1232 commented 7 years ago

@gotlium yeah, will do