get_quantities() got an unexpected keyword argument 'return_hdf5'

[bhorowitz]

I'm trying to run the first example ("python -m desc.wlmassmap.mocks.extract_footprint config.yaml") on NERSC with the protoDC2 catalog. It returns an error in extract_footprint.py;

Traceback (most recent call last):
  File "/global/common/cori/contrib/lsst/apps/anaconda/py3-envs/DESCQA/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/global/common/cori/contrib/lsst/apps/anaconda/py3-envs/DESCQA/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/global/homes/b/bhorowit/programs/WLMassMap/python/desc/wlmassmap/mocks/extract_footprint.py", line 58, in <module>
    extract_footprint(config['extract_footprint'])
  File "/global/homes/b/bhorowit/programs/WLMassMap/python/desc/wlmassmap/mocks/extract_footprint.py", line 47, in extract_footprint
    catalog.get_quantities(required_quantities, filters=filters, return_hdf5=filename)
TypeError: get_quantities() got an unexpected keyword argument 'return_hdf5'

It seems like get_quantities doesn't have a return_hdf5 option (https://yymao.github.io/generic-catalog-reader/index.html#GCR.BaseGenericCatalog.get_quantities). Perhaps it should just return the dict and then another line to output an hdf5 file?

[EiffL]

Thanks a lot Ben for fixing this bug !