search

LSSTDESC / WLMassMap

DESC utility for weak lensing mass-mapping
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Update and clean up package before making it public #24

Closed EiffL closed 4 years ago

EiffL commented 5 years ago

This PR restructures the package, removing useless stuff, and making it pip installable. This streamlined version is intended to be used for making the repo public

rmandelb commented 5 years ago

I would encourage you to update the README as recommended in the DESC's Repository Guidelines (which are guidelines, not policy, but they are intended to help avoid issues with licensing, misunderstandings of DESC pub policy, etc. so I do hope you will consider this suggestion!)

EiffL commented 5 years ago

Of course, thanks for pointing this out !

EiffL commented 4 years ago

I have made it compliant with the repo guidelines, given that this is not (yet) a DESC product. Note that I'm not making it public yet, this PR is mainly doing a loooot of cleaning up, bringing the project in the state of a clean software repo. We will be discussing the eventual "making the repo public" question in #16 Let me know @maho3 if you agree with this clean up.

maho3 commented 4 years ago

I think the original .yaml files currently in examples/ are outdated. They contain the old names of mmpipe functions and old configuration formats. I updated config.yaml with the new config_ceci.yaml, which works with ceci_pipeline. I'd suggest either removing these old .yaml files or updating them with new ceci-compatible ones.

EiffL commented 4 years ago

Awesome, thanks Matt!