search

LapisBlue / Pore

(Archive, not actively maintained) Run existing Bukkit plugins on Sponge natively
https://docs.lapis.blue/pore/
Other
61 stars 23 forks source link

My brane couldn't anglish. #11

Closed phase closed 9 years ago

phase commented 9 years ago

Small typo.

stephan-gh commented 9 years ago

Sponge is actually a (Forge) mod so both things are wrong

phase commented 9 years ago

I don't want to keep it at just "mod", as then it might be confusing on what it's a mod for.

caseif commented 9 years ago

This part of the README should probably be revised, but currently this PR retains the grammatical ambiguity (in that "which serves..." may appear to refer to Sponge rather than Pore.

Additionally, it should be kept in mind that Pore isn't limited to the official implementation (I.e. the Forge mod).

phase commented 9 years ago

@caseif Too much ambiguity...

jamierocks commented 9 years ago

to be honest anyone looking at pore source, should know what Sponge is xD

phase commented 9 years ago

@jamierocks Anyone looking at LapisBlue should know what Sponge is.

jamierocks commented 9 years ago

Change it to Pore is a plugin for the up-and-coming SpongeAPI which acts as a bridge to provide compatibility for Bukkit plugins on servers implementing SpongeAPI.

caseif commented 9 years ago

@jamierocks Eh, that sounds a little redundant. How about:

Pore is a plugin for the up-and-coming SpongeAPI built to provide compatibility for Bukkit plugins on the platform.

unascribed commented 9 years ago

Maybe:

Pore is a complete reimplementation of the Bukkit API on top of Sponge API.
It aims to allow you to run any Bukkit plugins on any Sponge server, be it
Quartz, Glowstone, the official Forge mod, or others. **Pore is currently
incomplete, and is not known to run any Bukkit plugins.** Contributions
are welcomed and encouraged.`

This replaces both mini-paragraphs with one paragraph. We may also want to mention that Pore will probably never run any plugins that require NMS.

caseif commented 9 years ago

@AesenV That's a bit long-winded IMO. I'd vouch for keeping it short and sweet.

phase commented 9 years ago

@caseif I'm going to have like 30 commits in this once it's over...

caseif commented 9 years ago

@phase I would use this to keep it more concise:

Pore is a plugin for the up-and-coming SpongeAPI built to provide compatibility
for Bukkit plugins on the platform. Please note that this project is still under
heavy development and **is not yet considered functional**. Currently, no Bukkit
plugins are verified to be supported.
caseif commented 9 years ago

Merged!

phase commented 9 years ago

@caseif Why didn't you merge this pull request?

stephan-gh commented 9 years ago

@phase It was merged, just rebased into one commit before being merged, that's why GitHub is not displaying this correctly

phase commented 9 years ago

@Minecrell Gotcha!