search

LapisBlue / Pore

(Archive, not actively maintained) Run existing Bukkit plugins on Sponge natively
https://docs.lapis.blue/pore/
Other
61 stars 23 forks source link

Update/data api #12

Closed Lamp-Post closed 9 years ago

Lamp-Post commented 9 years ago

Changed things:

stephan-gh commented 9 years ago

You need to fix the identation in some of the files. You can use one of our code styles in the Common repo to reformat your code

caseif commented 9 years ago

The Travis build is failing at the moment, so compile errors will need to be fixed before we can approve this.

caseif commented 9 years ago

The build still fails.

Lamp-Post commented 9 years ago

I am working on it:)

caseif commented 9 years ago

Sorry to be nitpickey, I just want to keep the codebase as uniform as possible.

Lamp-Post commented 9 years ago

Hahaha, no problem:)

caseif commented 9 years ago

Travis build still fails. You may want to run the Gradle wrapper locally before pushing.

caseif commented 9 years ago

Another nitpick: any chance you could revert the spaces added to the beginning of the TODO comments by the formatter, so the branch diff is kept to a minimum?

Lamp-Post commented 9 years ago

I know it still fails, but this due to some other files, that I haven't edited. I am still working on them. I will revert the spaces before the TODO's:)

caseif commented 9 years ago

Alright, thanks. Again, sorry to be a pain.

Lamp-Post commented 9 years ago

Hahahaha, It's alright I don't mind:)

caseif commented 9 years ago

@Lamp-Post Looks good. Is there anything else you want to change, or is it ready to be merged?

Lamp-Post commented 9 years ago

Well there are still a few little things I would like to change.

Lamp-Post commented 9 years ago

Now it is ready to be merged.

caseif commented 9 years ago

Merged via 70cd6d7. :)