Closed Lamp-Post closed 9 years ago
You need to fix the identation in some of the files. You can use one of our code styles in the Common repo to reformat your code
The Travis build is failing at the moment, so compile errors will need to be fixed before we can approve this.
The build still fails.
I am working on it:)
Sorry to be nitpickey, I just want to keep the codebase as uniform as possible.
Hahaha, no problem:)
Travis build still fails. You may want to run the Gradle wrapper locally before pushing.
Another nitpick: any chance you could revert the spaces added to the beginning of the TODO comments by the formatter, so the branch diff is kept to a minimum?
I know it still fails, but this due to some other files, that I haven't edited. I am still working on them. I will revert the spaces before the TODO's:)
Alright, thanks. Again, sorry to be a pain.
Hahahaha, It's alright I don't mind:)
@Lamp-Post Looks good. Is there anything else you want to change, or is it ready to be merged?
Well there are still a few little things I would like to change.
Now it is ready to be merged.
Changed things: