LapisBlue / Pore

(Archive, not actively maintained) Run existing Bukkit plugins on Sponge natively
https://docs.lapis.blue/pore/
Other
61 stars 23 forks source link

Data converter doesn't work with DataManipulators which aren't VariantData objects #21

Open caseif opened 9 years ago

caseif commented 9 years ago

Pore's data converter does not function properly if given a DataManipulator which is not a VariantData object. Subsequently, it needs to be modified to support all manipulators, and not just ones with a single value.

Case in point: Two of the (presently disabled) block data converter tests for minecraft:log and minecraft:log2 block types fail because AxisData no longer extends VariantData (previously SingleValueData in Data 1.0), so the converter doesn't know how to handle it and simply doesn't, providing an incorrect deabstracted value.