search

LapisBlue / Pore

(Archive, not actively maintained) Run existing Bukkit plugins on Sponge natively
https://docs.lapis.blue/pore/
Other
61 stars 23 forks source link

[WIP] Implement bans #23

Closed jamierocks closed 8 years ago

caseif commented 8 years ago

What was the verdict on this PR?

LunNova commented 8 years ago

Looks like it's missing some implementation here: https://github.com/LapisBlue/Pore/pull/23/files#diff-c9a78ead0f03eddda755835892724a01R115

// Correct me if I'm wrong, but Sponge doesn't seem to have the ability to change bans. // Perhaps remove the original Ban and create a new one?

Compilation failure here: https://github.com/LapisBlue/Pore/pull/23/files#diff-c9a78ead0f03eddda755835892724a01R65

PoreBanEntry.java:65: error: cannot find symbol this.expiration = handle.getExpirationDate().orNull();

jamierocks commented 8 years ago

The implementation is missing, because I am lazy. Actually it's not that hard but because I was in a rush and Sponge doesn't have this functionality.

caseif commented 8 years ago

Closing this for now in light of #29.