search

LapisBlue / Pore

(Archive, not actively maintained) Run existing Bukkit plugins on Sponge natively
https://docs.lapis.blue/pore/
Other
61 stars 23 forks source link

Ban implementation #29

Closed JBYoshi closed 8 years ago

JBYoshi commented 8 years ago
caseif commented 8 years ago

Looks good, aside from a few style issues. Let me know when those are fixed and you've finished implementing things and I'll merge it.

JBYoshi commented 8 years ago

@caseif Fixed those style issues. Although I added another set of method implementations which changed quite a bit of the ban stuff; could you make sure those other changes are OK?

caseif commented 8 years ago

Looks good to me, I'd like @Minecrell to take a look over the new changes though before I merge.

JBYoshi commented 8 years ago

Should be ready to merge.

jamierocks commented 8 years ago

This is not complete, there is still stuff left unimplemented.

JBYoshi commented 8 years ago

@jamierocks What parts?

jamierocks commented 8 years ago

Server#getIpBans() is one.

caseif commented 8 years ago

@JBYoshi Do you plan to complete work on this PR?

JBYoshi commented 8 years ago

Sorry about the delay. I'll try to finish it up today.

JBYoshi commented 8 years ago

@caseif Everything else should be implemented now. Ready for merge.

caseif commented 8 years ago

Merged, thanks!