Closed JBYoshi closed 8 years ago
Looks good, aside from a few style issues. Let me know when those are fixed and you've finished implementing things and I'll merge it.
@caseif Fixed those style issues. Although I added another set of method implementations which changed quite a bit of the ban stuff; could you make sure those other changes are OK?
Looks good to me, I'd like @Minecrell to take a look over the new changes though before I merge.
Should be ready to merge.
This is not complete, there is still stuff left unimplemented.
@jamierocks What parts?
Server#getIpBans() is one.
@JBYoshi Do you plan to complete work on this PR?
Sorry about the delay. I'll try to finish it up today.
@caseif Everything else should be implemented now. Ready for merge.
Merged, thanks!
BanList
BanEntry
setter methods