search

LapisBlue / Pore

(Archive, not actively maintained) Run existing Bukkit plugins on Sponge natively
https://docs.lapis.blue/pore/
Other
61 stars 23 forks source link

Improve PoreServer#enablePlugins(PluginloadOrder) #6

Closed jamierocks closed 9 years ago

jamierocks commented 9 years ago

Also PoreWrapper doesn't need to be abstract.

stephan-gh commented 9 years ago

The question here is, why shouldn't PoreWrapper be abstract?

jamierocks commented 9 years ago

@Minecrell you ask a good question, but...

maxov commented 9 years ago 
16:10 <@gratimax> lexteam: nice catch
16:10 <@gratimax> no particular reason why it shouldn't be, lol
16:10 <lexteam> ok, ill put that in my pr
16:10 <@gratimax> well
16:10 <@gratimax> there might be some extra methods added later on
16:11 <lexteam> shall i change it?
16:11 <@gratimax> uhm
16:11 <@gratimax> keep it as is?
16:12 <@gratimax> not really breaking anything, lol
16:12 <@gratimax> if it really makes you happy, put in in the pr :P
16:12 <lexteam> ok :p