Laura10101 / contractor-tax-calculator

0 stars 2 forks source link

Config app not displaying rules for selected jurisdiction #189

Closed Laura10101 closed 10 months ago

Laura10101 commented 10 months ago

Steps to reproduce

  1. Go to the config app
  2. Select a jurisdiction known to have rules defined

Expected result All rules for the selected jurisdiction are displayed under the appropriate ruleset and in order.

Actual result No rules are displayed for the selected jurisdiction

Laura10101 commented 10 months ago

The rules API is not including the rule type in the serialised rule when returning a response. As a result, the config app does not know which rule type to display for each rule. Resolved by adding the rule type into the serialised rule.