search

LazoCoder / Pokemon-Terminal

Pokemon terminal themes.
GNU General Public License v3.0
4.19k stars 224 forks source link

give support for KDE konsole terminal #181

Open ishank-dev opened 4 years ago

Atem18 commented 4 years ago

+1 would be nice

dofrancis commented 3 years ago

I think the reason why it hasn't been implemented is because there is no way to change the background through commands.

sylveon commented 3 years ago

Yeah, if there's a way feel free to PR it or tell us how.

Atem18 commented 3 years ago

Then let me ask on their Gitlab

EDIT: https://invent.kde.org/utilities/konsole/-/issues/9

EDIT2: They said to open a bug on their bugzilla: https://bugs.kde.org/show_bug.cgi?id=424221

cfeck commented 3 years ago

Is there a standard ESC sequence that KDE's Konsole needs to implement? I didn't find any reference.

sylveon commented 3 years ago

This tool has a backend for each terminal it supports, since there is no standard - so however Konsole implements it we shouldn't have trouble supporting it.

For example, tilix and terminology use a command line tool, but Windows Terminal support directly edits the configuration file.

cfeck commented 3 years ago

The "problem" is that Konsole supports multiple profiles, and I am not sure if your intention would be to A) modify all profiles, B) modify only the default profile, C) modify the currently selected profile, or D) create an own profile with your modifications.

MiChaelinzo commented 3 years ago

Yes please !!!!! pokemon

kevinmody commented 2 years ago

Hey guys, I am Kevin and I am a cs student. I was hoping to contribute to this repository and maybe learn/help from it.

ask-compu commented 1 year ago

The "problem" is that Konsole supports multiple profiles, and I am not sure if your intention would be to A) modify all profiles, B) modify only the default profile, C) modify the currently selected profile, or D) create an own profile with your modifications.

maybe copy the currently selected profile into a new one and modify that? then set that as the currently selected profile? that makes the changes easy to undo so it isn't destructive, just need to figure out a way to identify if a profile is made by this app so it doesn't just endlessly make new profiles