search

LazoCoder / Pokemon-Terminal

Pokemon terminal themes.
GNU General Public License v3.0
4.19k stars 224 forks source link

Typo in using python re library -- supposed to be lowercase :) #189

Closed ProNibs closed 3 years ago

ProNibs commented 3 years ago

https://github.com/LazoCoder/Pokemon-Terminal/blob/154d0354350f50b4867dd6e254ecc0570ac47e51/pokemonterminal/terminal/adapters/windowsterminal.py#L38

sylveon commented 3 years ago

It's not - re.Match is a type (a match object passed in by re.sub()) and re.match() is a function.

You can easily see this by typing both in a Python REPL: image

ProNibs commented 3 years ago

I just installed this locally, and the error I was getting was re.Match() doesn't exist. Also, doing locally as you suggested when using Python 3.6.5 does not find that library. I had to go into the file manually and lowercase it and it started working, so maybe it's just my environment that was having this issue.

sylveon commented 3 years ago

Ah, my bad, seems like it was added with Python 3.7: https://github.com/python/cpython/commit/0b5e61ddca73ad4fe597fb15065115b0285c8849

I'll update the requirements to mention Python 3.7

ProNibs commented 3 years ago

Cool beans, glad I could help 👍