search

LazoCoder / Pokemon-Terminal

Pokemon terminal themes.
GNU General Public License v3.0
4.19k stars 224 forks source link

Add support for Konsole #193

Open PrimaryCanary opened 3 years ago

PrimaryCanary commented 3 years ago

The code isn't great but it works well enough in my testing.

I didn't see these issues when I started but fixes https://github.com/LazoCoder/Pokemon-Terminal/issues/181 and part of https://github.com/LazoCoder/Pokemon-Terminal/issues/192.

PrimaryCanary commented 3 years ago

Pinging @sylveon to get some eyes on this.

sylveon commented 3 years ago

I don't use Linux anymore so I can't validate this - somebody like @samuelhnrq would probably be better

samuelhnrq commented 3 years ago

Sorry people, been busy with my job lately, will try to test it this week. Does this implementation need integration with plasma or Konsole running on gnome would be enough for testing?

PrimaryCanary commented 3 years ago

I only tested on Plasma. It will work as long as ~/.local/share/konsole/Pokemon.colorscheme exists and is a valid colorscheme or link to a valid colorscheme.Nov 24, 2020, 05:04 by notifications@github.com:

Sorry people, been busy with my job lately, will try to test it this week. Does this implementation need integration with plasma or Konsole running on gnome would be enough for testing?

— You are receiving this because you authored the thread. Reply to this email directly, > view it on GitHub https://github.com/LazoCoder/Pokemon-Terminal/pull/193#issuecomment-732921443> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/AK7RIMLUZ3LVCD3NII6K6W3SROOOTANCNFSM4TOBS42A> .