LazoCoder / Pokemon-Terminal

Pokemon terminal themes.
GNU General Public License v3.0
4.22k stars 226 forks source link

[Request] Hyper Terminal Support #25

Closed DuIslingr closed 7 years ago

DuIslingr commented 7 years ago

I would love to see this available for Hyper on Windows/Linux/and Mac. It does utilize Electron so idk how difficult it would be to get it to work.

https://github.com/zeit/hyper

klaudiosinani commented 7 years ago

Love the project ❤️ Started building a hyper version last night;

https://github.com/klauscfhq/hyper-pokemon

Here are a few screenshots​ Screen

Screens

sylveon commented 7 years ago

I wonder if it could be possible to integrate it in this project instead of making it completely separate.

klaudiosinani commented 7 years ago

I think it would be really hard, since Hyper is build solely on web technologies. Though you could definitely try. Plus building it natively for Hyper could open up new applications, like support for the Atom text editor and other Electron apps.

DuIslingr commented 7 years ago

@klauscfhq You my friend have earned yourself a star from me :p

LazoCoder commented 7 years ago

It wouldn't be hard to do this. Its really just a two step process:

  1. Locate Hyper's config file.
  2. Inject the following code:

    module.exports = {
    css: `
    .terms_terms {
      background: url(file://path-to-pokemon-image) center;
      background-size: cover;
    }
    `,
    
    termCSS: `
    x-screen {
      background: transparent !important;
    }
    `
    };
klaudiosinani commented 7 years ago

It is not just that, there are other things also involved, and you should probably know that this way of using background images is not an officially supported one by Electron, which means that it might completely change with a new release. Also there are other things to take into account, such as providing support for other Hyper related features and issues, that would require a more JavaScript oriented codebase instead of Python one. Plus you are cutting down a whole OS platform on the original project, the Windows one, which with hyper is supported. In addition there is a whole ecosystem of already available color-schemes & plugins that could be combined with the Pokemon backgrounds on Hyper and supporting them would definitely​ be a serious extra development weight on the existing project. Again, you can definitely try applying it. Just to be clear, i have not forked your code, i am just using your concept as an inspiration to build new things, like the Hyper theme, a future Atom theme, Trello themes, Caprine themes etc.

EDIT: The snipset provided above does not depict how a Hyper theme/plugin works, it is just a portion of the .hyper.js where the user settings are stored. Also, setting directly background images in that fashion, might not mix well with other plugins that the user could add : )