Le0Michine / FusionGridfinityGenerator

Other
629 stars 40 forks source link

Feature Request: Add option for 3-tiered supportless counterbore holes #13

Closed mmmyers closed 1 year ago

mmmyers commented 1 year ago

Could you change to the 3-tiered counterbore holes, instead of the 2-tiered one, or make it able to change the style as an option in the creation option? Here's a picture of the type of change I mean.

image

For whatever reason, on my printer, the 3-tiered ones print a lot better. Here's an example of the 2-tiered ones in the current plugin on the left, and 3-tiered ones afterwards:

2-tiered hole: image

3-tiered hole: image

Le0Michine commented 1 year ago

thanks for your feedback, I'll try to experiment with that

mmmyers commented 1 year ago

I decided to go and learn the F360 Python API and do it myself. I created a pull-request for you.

Hope it helps. I've already found this project useful, so I figured I could contribute a feature that would be helpful for me.

Le0Michine commented 1 year ago

haha, I was working on exactly that this morning

mmmyers commented 1 year ago

Sorry, I probably should have told you I decided to try my hand at it myself. Haha.

Le0Michine commented 1 year ago

thanks for the PR, I appreciate that, and I'm sorry I changed the code quite a bit so it seems unmergeable now, mostly because I got rid of the groove related sketch completely

Le0Michine commented 1 year ago

I simplified the way the groove is created, let me know if you get a chance top test that

mmmyers commented 1 year ago

I just tested out your update. Works for me! Thank you very much.