Le0Michine / FusionGridfinityGenerator

Other
629 stars 40 forks source link

3-tier supportless magnet + screw holes #14

Closed mmmyers closed 1 year ago

mmmyers commented 1 year ago

Decided to learn how to use the F360 Python API and contribute, since I find your plugin useful.

This should add an extra extrusion to cut out another layer from the supportless magnet + screw holes, which will allow many slicers to print this a bit more neatly.

I'm not exactly a python programmer at my day-job, so please feel free to suggest edits, if my code isn't idiomatic, or if I've done something dumb.

Here's a screenshot of how it looks, when generating a bin: image

Example of how the old version prints, on my printer: image

Example of how the new version prints, on my printer: image

Le0Michine commented 1 year ago

thanks for the PR, unfortunately latest commit makes it impossible to merge. However the second layer groove was added as well, so it should resolve the issue you are facing

Le0Michine commented 1 year ago

I'm gonna close this, please feel free to open a new one or create an issue if updated functionality doesn't cover your use case

mmmyers commented 1 year ago

Not a problem. As long as it's solved. I had fun learning the API, so it wasn't a waste at all.