Le0Michine / FusionGridfinityGenerator

Other
629 stars 40 forks source link

Section dividers are too high #20

Closed tache closed 11 months ago

tache commented 1 year ago

First of all - this is awesome!

The section dividers are too high to allow proper stacking. This is a two compartment bin with wall down the middle.

stacked

IMG_5994

Left Stackable - Right Generated

IMG_5997

Le0Michine commented 1 year ago

Hi, thanks for pointing this out, I'll take a look

tache commented 1 year ago

I was trying to dig into the code to do a PR, but I am not too up to speed on python and have zero knowledge of Fusion 360 plugins. I think if I understand how you build up a bin, that adding a cut on the compartment as the final step. Here I did it manually in F360. After generating, I did the extrude function, selected the compartment divider, set to cut, at 1mm - the picture is the result. When I was digging into the code, my thought was to add a "compartment height" to the Bin compartment of the configure dialog, so it would be configurable.

Screen Shot 2023-04-22 at 2 49 03 PM
Le0Michine commented 1 year ago

looking closer, it seems like the the depth should be right, at least comparison with original shows that it is in line with the label tab there, interesting

image

Le0Michine commented 1 year ago

the distance from the base to the top of the dividers is 6u on the picture. Seems like if you add label tab you will get same issue, I'm wondering if adding a second level chamfer for the lip would help

image

tnoppeney commented 1 year ago

Just by stacking two 1x1x1 containers in Fusion 360 already shows the issue:

grafik

The overlap in my case is .35mm.

Le0Michine commented 1 year ago

yeah, but still, not sure if reducing height of the dividers is the right approach to correct this. Ideally if you have 3 bins each 2U height they should stack and be on the same level as a single bin 6U height, so you should be able to put another bin on top of them. Something like on this picture

image

If we just cut on divider height we would get into this situation

image

Le0Michine commented 1 year ago

It seems like the lip needs to be higher, about 0.3mm or so. Which would be ~4.7mm instead of 4.4mm on top of the bin height. Also as mentioned before, there is a label tab feature which would be generated at the same height as divider top edge

Le0Michine commented 1 year ago

looking at the original design and it seems like it would have the same issue, even with extra chamfer at the bottom because it has the same clearance allowing the bin to potentially slide further down than it is supposed to

image

tache commented 1 year ago

Any status on this one? I was thinking about maybe having the ability to set the section divider height might be an interesting option in the dialog. I.e., you could have a 6U bin, but wanted to have a 3U divider.

Le0Michine commented 1 year ago

sorry didn't have enough time to print these and experiment more. I don't think lowering dividers is the right way to go due to reasons mentioned above, it might solve the issue you are experiencing but it seems like it might introduce another one. I would prefer not to add an extra option either to keep UI as simple as possible. I was going to experiment a bit with the lip clearance and height as it looks like that's the root cause

tnoppeney commented 1 year ago

image

In this picture you are giving the bins tolerance on the sides (there are gaps) but not on top of the divider (there is not gap).

I printed 1x1 bins with dividers and it basically is as I expected and as it has been shown by tache: the top bin sits basically on the divider of the bottom bin and you can wiggle it left or right. This is definitively not how it should be.

Printing it with a divider 0.3mm shorter (as I suggested above) eliminates the issue and the top bin sits in the bottom bin exactly the same as if it wouldn't have the divider (and that should be the correct behavior). The divider or label tab should not be responsible for making sure, that the top bin does not sink in to much, because (at least for my case) most of my bins don't have either of those.

Here is a bunch of boxes stacked together and the bottom left has a shortened divider, still everything adds up nicely: image

mjs3350 commented 1 year ago

I came here to mention that label tab makes contact with the base before the stacking lip when stacking bins. Looks like this is the same issue.

tache commented 1 year ago

Is this still an open issue? I see releases, but they do not mention this issue.

Le0Michine commented 1 year ago

it is still open, I was gonna take another look, but have been busy lately so other things were prioritized

Le0Michine commented 1 year ago

did a bit of experimentation and it seems like tab and compartment walls can be adjusted to be slightly lower, here is how it looks like with 0.25mm clearance

Screenshot 2023-07-14 142103 Screenshot 2023-07-14 142006 Screenshot 2023-07-14 141937

Le0Michine commented 1 year ago

pushed updated version, you can update and try it out, let me know if you still seeing the issue

tache commented 1 year ago

Great! I will give it a spin when my long print finishes.

tache commented 12 months ago

Hey this is much better, but a tiny bit off. I am thinking somewhere like 1 mm, but not more than 1.5mm

Tested with two 2x3 bins, with a dividers as shown.

Bin-Stack - 1

2x3 bin bottoms.

Bin-Stack - 4

This picture has the bin with the divider longways on the bottom. So the divider does not hit the bottom since it is in the middle cutout.

Bin-Stack - 2

This picture has the bin with the divider shortways on the bottom. You can see that the bottom of the top sits on the divider

Bin-Stack - 3

Le0Michine commented 12 months ago

Hmm, can you confirm if the bottom of those bins is flat? Not sure if just the corners curled up or the whole thing shrank.

Also, what layer height you used?

tache commented 12 months ago

Yes they are flat. Here are the settings.

Bin-Stack - 5

settings

tache commented 12 months ago

I just noticed another artifact on the dividers. It bleeds through to the outside. Here are the two bins, one had a divider in the short side, then other in the long side.

Bin-Stack - 6a

Bin-Stack - 7a

Le0Michine commented 11 months ago

The last one is likely related to your print settings. That also might be unavoidable for thinner walls.

Le0Michine commented 11 months ago

here you can barely see it, even though layers quality is quite bad for this particular print

IMG_3125

Le0Michine commented 11 months ago

I'm gonna close this for now, feel free to reopen if the issue still persists