Le0Michine / FusionGridfinityGenerator

Other
629 stars 40 forks source link

Base interface features don't take basic sizes into account #21

Closed tnoppeney closed 1 year ago

tnoppeney commented 1 year ago

Hi,

I want to create bins with a base size 36x36mm and magnet holes, but those do not consider the dimensions and seem to be placed as if the bin was still 42x42mm in size:

grafik

Le0Michine commented 1 year ago

that's a limitation which was there from the start, need to figure out a proper way to generate those sockets. Maybe specifying offset or distance between when would be useful.

Could you share your expectations for how this part is supposed to work? Do you want to have completely custom grid size with your own socket spacing? Or are you trying to create something somewhat backwards compatible?

tnoppeney commented 1 year ago

My expectation was that the sockets would maintain their distance from the edge no matter what the size was set to.

Le0Michine commented 1 year ago

thanks for the update, I'll take a look once I have some time, probably shouldn't be too hard to add 🤔

Le0Michine commented 1 year ago

Updated the way holes position is calculated, now it is counted from the bin side so it should scale to some degree for smaller bins better

Screenshot 2023-07-03 at 12 13 21
Le0Michine commented 1 year ago

that includes baseplates

image
Le0Michine commented 1 year ago

unfortunately it won't work as well with half width bins

image

But it is possible to partially suppress pattern feature to get holes only on one side so they still could be compatible with standard baseplates

image image
Le0Michine commented 1 year ago

because it is an old issue I'm gonna close it for now, feel free to reopen if you still run into problems with it or create a new one