Le0Michine / FusionGridfinityGenerator

Other
629 stars 40 forks source link

Offset Bug #31

Closed eMJay1805 closed 1 year ago

eMJay1805 commented 1 year ago

When creating the base, an edge is created, which means that the container does not go in well.

image

scriptnugget commented 1 year ago

I just encountered this as well, in both the baseplate and container. In the timeline I found the cause, in both cases being the 'thicken'-command offsetting some but not all required faces. Editing the feature and reselecting the correct faces (with the chain select option on) fixes the model.

Le0Michine commented 1 year ago

Hi, Could you provide a screenshot with your inputs? Is that an issue with baseplate or something else? I can't reproduce it with standard values

scriptnugget commented 1 year ago

baseplate_settigns baseplate_overhang bin_settings_1 bin_settings_2 bin_overhang

I made these screenshots without changing any input values, and this is with the latest version of the plugin. I reinstalled the plugin last week before I posted here, the issue still persisted.

eMJay1805 commented 1 year ago

Little Video https://www.youtube.com/watch?v=bTtyo-TPZzQ

Le0Michine commented 1 year ago

Tried to reproduce again with suggested values (seems like those are just defaults) and I'm getting a different result, not sure what could be the cause

image

Le0Michine commented 1 year ago

noticed that on the your pictures the baseplate model doesn't have clearance between bin overhang and baseplate chamfer this might indicate that some offset operation did get executed for some reason. Can I ask you to export fusion project file and attach it here so I can inspect each operation?

eMJay1805 commented 1 year ago

FusionGridfinityGenerator v1.zip I only created the base and the bin. All settings are standard. Do you have Fusion personal edition or full version? I have the Personal Edition.

Le0Michine commented 1 year ago

I use personal version. Looks like I can't open your file yet, seems like my fusion didn't get to update and isn't on the latest version. I don't quite see how to force it to update either and official guide isn't very helpful https://www.autodesk.com/support/technical/article/caas/sfdcarticles/sfdcarticles/How-do-I-download-updates-for-Fusion-360.html

Forward compatibility is not supported:2.0.16490 - The file you are trying to open was last saved in a newer version of the software. It cannot be opened!
Persisted Software version: 2.0.16490

Current Software version: 2.0.15775 

seems like I'll have to wait for update to happen, hopefully it will catch up within a day or two

robi000001 commented 1 year ago

Hi! I also use a recent version of fusion and encountered the same issue. All settings are default. I attach some screenshots, maybe they help. Gridfinity Gridfinity-2

robi000001 commented 1 year ago

It seems that the new fusion version have a bug (or a new feature). After extending the "bin base side faces", the next feature fails to select all the relevant faces. By omiting the line: 222 features.extendFeatures.add(extendClearanceSurfaceFeatureInput) from baseGenerator.py, it seems to solve the problem (but I do not consider it a proper fix). Gridfinity-3 Gridfinity-4 Gridfinity-5

Le0Michine commented 1 year ago

that makes sense, I suspected something was happening around that offset operation. I'll try to play around and see if I can replace it with something else or improve stability. Will also try to reinstall fusion as it doesn't seem like it is going to find a new version

Le0Michine commented 1 year ago

Pushed a fix, let me know if you still experience the issue after update.

Some details: looks like the issue was caused by some internal changes in fusion. To get clearance for bins to sit into the baseplate I use thickening feature. To do that I create surface with 0 offset from the bin base walls. At this point I get 24 faces. Then I extend the top faces up to ensure clean cut with the baseplate. In earlier fusion versions the amount of faces on the object referencing surface offset feature would still be 24, but with the newer version the top 8 faces used with extend feature are removed from that list. The commit above adds those missing faces explicitly to make sure they are not omitted anymore.

robi000001 commented 1 year ago

The fix seems to work perfectly :) Thank you. Gridfinity-b1 Gridfinity-b2

Le0Michine commented 1 year ago

thanks for confirmation, closing the issue for now