search

Le0Michine / FusionGridfinityGenerator

Other
623 stars 40 forks source link

Allow zero bin lip top recess height #77

Closed bartbergman closed 5 months ago

bartbergman commented 5 months ago

I noticed that the top lid of my bins was cut off a bit. After some code inspection I noticed this was intentional and set by the bin lip top recess height. I tried setting the BIN_LIP_TOP_RECESS_HEIGHT to zero, but that resulted in an error. This is a fix for those who want to stick to the Gridfinity Design Reference (https://gridfinity.xyz/specification/)

Le0Michine commented 5 months ago

Hi, thanks for submitting a PR. I wanted to clarify if you could provide more details behind reasoning for this change.

For the context, the change was made to avoid having sharp edges which physically cannot be printed by consumer FDM machine. Normally slicers would just make that cut at a time of slicing the model, however, sometimes this could cause some slicers to generate weird results with either single perimeter wall which is harder to get printed well or some artefacts like the one on the picture below. So while generally the application would try to produce the results as close as possible to the spec there are some minor adjustments making it more it easier to slice/print as this is the ultimate goal of the whole process.

image

bartbergman commented 5 months ago

I already suspected that this was the reason. That's why I didn't remove anything, just prevented the error when setting the BIN_LIP_TOP_RECESS_HEIGHT constant to zero. For those with some form of OCD that like to see a total height of (Units * 7 mm) + 4.4 mm for a bin with stackable lip ;)

Le0Michine commented 5 months ago

included more objects into the if branch, the change will be included into the next release