Le0Michine / FusionGridfinityGenerator

Other
711 stars 48 forks source link

Add tabs to magnet cutouts (alternative to PR #85) #87

Closed gbrunow closed 5 months ago

gbrunow commented 7 months ago

This is a combination of the work done by @CuddlyTurtle on PR #85 and this fork by @software-2. I used the UI changes by @CuddlyTurtle and the cutous by @software-2. Resulting in the following:

image

Quoting @CuddlyTurtle:

for people that use pressfit instead of glue.

This is a proof of concept that needs refinement by someone that uses pressfit. Areas of future consideration:

  • Removing 1/4 of the surface area when you press-fit seems counter-productive. Less should be more.
  • Some press-fit models make the tab even deeper than the magnet hole so you can get a tool under the magnet when prying it out.
  • At least for asthetic reasons it would probably be nicer to tave all tabs poing towards the middle.
CuddlyTurtle commented 7 months ago

I like it! We should probably spend some time considering if we could make the text in options more self-documenting though. Preferably without making an essay. Like "Add tab to magnet cutout to aid with pressfit", but with fewer words.

"Add pressfit tabs to sockets" since it's right below the option for adding sockets now?

gbrunow commented 7 months ago

I like it! We should probably spend some time considering if we could make the text in options more self-documenting though. Preferably without making an essay. Like "Add tab to magnet cutout to aid with pressfit", but with fewer words.

"Add pressfit tabs to sockets" since it's right below the option for adding sockets now?

That's a good point.

I also thought about adding a dropdown for magnet cutout type (None, glue, press fit, custom) then asking for the magnet size instead, we could have the clearance by transparent to the user. I didn't want to make too many changes at once though.

gbrunow commented 7 months ago

@CuddlyTurtle do you think mentioning "press fit" could be misleading since the users would still be expected to adjust the cutout diameter? The cutout doesn't really have anything to do with press fit, right? It just allows you to remove the magnets if needed.

CuddlyTurtle commented 7 months ago

Well, you are only going to remove them if you haven't glued them, so the connection is there. You are right that this might give the impression that this will magically make the cutout press-fit ready since it's the only place that mentions it.

The UI needs a redesign and perhaps dynamic elements beyond what Fusion can provide to make it more obvious. Something for another pull.

gbrunow commented 7 months ago

Well, you are only going to remove them if you haven't glued them, so the connection is there. You are right that this might give the impression that this will magically make the cutout press-fit ready since it's the only place that mentions it.

The UI needs a redesign and perhaps dynamic elements beyond what Fusion can provide to make it more obvious. Something for another pull.

Agreed!

Le0Michine commented 6 months ago

Hi, thanks for taking the time to investigate and implement, this looks interesting, I'll try to take a look hopefully within a couple weeks

Le0Michine commented 5 months ago

looking closer at this, it seems there is an issue when combined with screw holes which will not print well, I think it could be addressed by positioning the tabs differently or by rotating printability feature by 45 degree

image

Something like this could work

image
Le0Michine commented 5 months ago

made a few changes adding functionality proposed by this PR, it is available when installing from sources now and will be added into the next version, closing the PR for now

no screws with screws
image image