search

LeaVerou / inspire.js

Lean, hackable, extensible slide deck framework. Previously known as CSSS.
https://inspirejs.org
MIT License
1.73k stars 254 forks source link

Speed-up font resizing #20

Closed sleeper closed 12 years ago

sleeper commented 12 years ago

Hi,

Here's a refactored version of the previously submitted patch to improve the font resizing algorithm.

LeaVerou commented 12 years ago

I originally merged this pull request, but I had to revert back because I see a couple issues with it. First and foremost, there's an error thrown from leaving in variables that were in the previous function (like min_value) which indicates that this has probably not been tested sufficiently, if at all. I can easily fix the min_value issue, but if I'm not risking other problems with it due to insufficient testing.

Secondly, its coding style is very different from the rest of the script. Although, I wouldn't mind converting that myself, if it wasn't for the first issue.

In any case, thank you very much for your time contributing to this project. No matter what happens with the pull request, it's appreciated.

sleeper commented 12 years ago

OK, seems some errors manage to go through .. Actually I tested it in an hurry at the conf, so I guess I did not see this one. I'm going to see if I can add some unit test. Sorry to be so insistent on this patch, but I really like these templates, and would like to use them for future presentations too, but cannot have too much lag between some of the slides (the laggish ones were displaying some formated code, meaning they are not short ;) ).