search

LeaVerou / inspire.js

Lean, hackable, extensible slide deck framework. Previously known as CSSS.
https://inspirejs.org
MIT License
1.73k stars 254 forks source link

Gestures #25

Open nono opened 11 years ago

nono commented 11 years ago

Hi,

I've added support for gestures on smartphones (see #3). In therory, it should work on firefox, android, ios safari and blackberry if I believe http://caniuse.com/#feat=touch but I don't have the devices to test them all.

LeaVerou commented 11 years ago

Hi nono,

Sorry for the delay in getting back to you. This looks great and it's a long overdue feature, thank you!! Do you have any demo anywhere so that I could test it a bit before I merge?

Thanks!

nono commented 11 years ago

Hi,

no problem, you can test it on http://blog.menfin.info/Presentations/20121018_Mobile_apps/ .

LeaVerou commented 11 years ago

Hey, thanks. Which devices have you tried this on? I just tried it on my iPhone and I can't seem to get it to work.

nono commented 11 years ago

Firefox and chrome on an android device, and chromium on my desktop by emulating touch events.

LeaVerou commented 11 years ago

It doesn't seem to be working at all on iOS. If it will help, I can send you my browserstack info so you can test it for yourself. :)

nono commented 11 years ago

Yup please, it's better than nothing ;-)

nono commented 11 years ago

Well, it works but it was very difficult to trigger the gestures on iphone. I've changed some parameters and I hope it's better now. You can try the new version on http://www.menfin.info/csss/. Does it work on a real device?

By the way, the current geasture for moving to the next slide is a move from left to right. And right to left for moving to the previous slide. But maybe, the inverse is better. What do you think?

nono commented 11 years ago

@LeaVerou: I'm sure you are busy, but if you find some time to test it, please let me know.

nono commented 11 years ago

Hi Lea, did you find the time to test it?

LeaVerou commented 11 years ago

Sorry not yet :( But thanks for reminding me.

nono commented 11 years ago

Hi @LeaVerou, this is a new reminder for this pull request. I hope you will have some time for it this time.

nono commented 10 years ago

@LeaVerou this is yet another remainder. Maybe you have some time for it now.

LeaVerou commented 10 years ago

Shit, I’m so, so sorry I haven't reviewed this yet. :(

Btw there are merge conflicts now it seems. Could you please pull in any changes and resolve the merge conflicts? There shouldn't be many.

Again, thanks so much for this and I'm sorry I'm being so busy :(

nono commented 10 years ago

Don't worry, I know what it is to have a lot of stuff ;)

I've rebased my commits and fix the conflicts (they were trivials). So, you should be able to merge them without pain.

nono commented 10 years ago

@LeaVerou a quick remainder