search

LeaVerou / inspire.js

Lean, hackable, extensible slide deck framework. Previously known as CSSS.
https://inspirejs.org
MIT License
1.73k stars 254 forks source link

Bugfix in css-controls.js #7

Closed henrikekelof closed 13 years ago

henrikekelof commented 13 years ago

Line 18 in css-controls.js need to be: CSSEdit.setupSubjects(control) is now: CSSEdit.setup(control);

LeaVerou commented 13 years ago

Oops, you're right! I originally named the method "setup" and forgot to change it later. Can you please send a pull request?

Cheers, Lea

Lea Verou Web designer & developer, specializing in front-end development leaverou.me http://leaverou.me • Twitter http://twitter.com/LeaVerou • LinkedIn http://gr.linkedin.com/in/leaverou

On 5/9/11 15:17, henrikekelof wrote:

Line 18 in css-controls.js need to be: CSSEdit.setupSubjects(control) is now: CSSEdit.setup(control);

henrikekelof commented 13 years ago

I just did, but I'm pretty new to GitHub so I might have done something wrong. I´ll check.

By the way, I´m using CSSS for the first time (I saw you at Robert Nymans Geek Meet in Stockholm). I love it - thanks!

/Henrik

On måndag 5 september 2011 at 14:18, LeaVerou wrote:

Oops, you're right! I originally named the method "setup" and forgot to
change it later. Can you please send a pull request?

Cheers, Lea

Lea Verou Web designer & developer, specializing in front-end development leaverou.me http://leaverou.me • Twitter http://twitter.com/LeaVerou
• LinkedIn http://gr.linkedin.com/in/leaverou

On 5/9/11 15:17, henrikekelof wrote:

Line 18 in css-controls.js need to be: CSSEdit.setupSubjects(control) is now: CSSEdit.setup(control);

Reply to this email directly or view it on GitHub: https://github.com/LeaVerou/CSSS/pull/7#issuecomment-1998792

LeaVerou commented 13 years ago

Interesting, I didn't know I can reply to pull requests through email. Not sure why it has 5 commits, and 4 of them mine. That's strange. And I can't merge it. Could you please try once more, I'm gonna close this one. I'm not very good with git/github either, so don't worry if you do something wrong. :)

Glad you like CSSS!