search

LeagueOfPoro / EsportsCapsuleFarmer

Automatically watch all live matches on lolesports and farm Esports Capsules
https://www.youtube.com/c/LeagueOfPoro
Other
95 stars 23 forks source link

Refactor main.py #65

Closed DjordyKoert closed 1 year ago

DjordyKoert commented 1 year ago

I have improved main.py by splitting the code into their own corresponding classes.

This has been done to:

  1. Improve developer experience (Fixing bugs, implementing new features)
  2. Make the main.py file easier on the eye and reduce the risk of implementing bugs
DjordyKoert commented 1 year ago

I also got an error during the creation of the .exe "ModuleNotFoundError: No module named 'macholib'". I did a pipenv install macholib to fix this.

LeagueOfPoro commented 1 year ago

It looks macholib is Mac OS X specific

DjordyKoert commented 1 year ago

It looks macholib is Mac OS X specific

Okay, i have reverted that commit 😁

LeagueOfPoro commented 1 year ago

Ah, you didn't check "Allow edits from maintainers." so I cannot commit to the pull request. Anyway, thanks and merging.