Windows demo crashing immediately on play

Lecrapouille / gdcef

[Plugin][Version 0.13.0][Functional] Chromium Embedded Framework Webview for Godot 3 and 4

https://discord.gg/EckEwy7S5U

MIT License

268 stars 31 forks source link

Windows demo crashing immediately on play #11

Closed daniel-sanche closed 2 years ago

daniel-sanche commented 2 years ago

Hey, great project!

I tried compiling this for windows and linux. Linux worked great, and I was able to run the sample projects by following the documentation.

For windows, compilation seems to finish successfully, but when running the sample project, it exits immediately as soon as I press "run", with no errors printed to the console. I've tried using different versions of godot, and compiling from previous releases, but I'm getting the same result.

Any ideas what I am missing?

Lecrapouille commented 2 years ago

@daniel-sanche Hello ! Sad :( AFAIK I do not have Windows (and from VirtualBox, Godot or my application cannot start since needs Vulkan which is not supported) so I work blindly for this OS. @steacktartar made it work for Windows, but he does not work anymore, and he is busy now. I'll try to ping him. Else @raphipod are you free to help ?

Else to be sure:

Godot 3.4 or 3.5 (I never tried with Godot 4).
I use aliases to refer to the build/ folder. Windows does not like them (need to be admin). Check if they are present.
Are .gdns and .gdnlib are well-defined for Windows (I set .dll but maybe its .lib) ?
You can launch the application from Godot and without it: by crash you mean Godot also crash ? By 'previous releases' do you mean CEF or Godot ?

Lecrapouille commented 2 years ago

@daniel-sanche @raphipod told me Godot doesn't get the build files from CEF, so you have to put the Godot executable into the build folder for the project to run if true maybe I made a regression here https://github.com/Lecrapouille/gdcef/blob/8ae2774ac708aa89087ac88079c7276f4cd78b5d/addons/gdcef/gdcef/src/gdcef.cpp#L95 calling https://github.com/Lecrapouille/gdcef/blob/8ae2774ac708aa89087ac88079c7276f4cd78b5d/addons/gdcef/gdcef/src/gdcef.cpp#L76 calling https://github.com/Lecrapouille/gdcef/blob/8ae2774ac708aa89087ac88079c7276f4cd78b5d/addons/gdcef/gdcef/src/helper.cpp#L84

Lecrapouille commented 2 years ago

@daniel-sanche Can you test the HEAD of the master branch ? I tried a fix !

raphipod commented 2 years ago

Confirmed working with commit 2fca3a0 on my end. No need to put the Godot Editor executable in the Build folder anymore now! @daniel-sanche, does it work on your end?

daniel-sanche commented 2 years ago

Yeah looks like that worked, thanks!

Lecrapouille commented 2 years ago

@daniel-sanche Ok nice, I fixed it blendy :) Ok so I'll tagged it and send it back to the Godot asset lib