Removed URL percent encoding (#1) & other improvements

Lecrapouille / gdcef

[Plugin][Version 0.13.0][Functional] Chromium Embedded Framework Webview for Godot 3 and 4

https://discord.gg/EckEwy7S5U

MIT License

268 stars 31 forks source link

Removed URL percent encoding (#1) & other improvements #2

Closed raphipod closed 2 years ago

raphipod commented 2 years ago

Changes in build.py:

CEF-Version updated
OS name check causes build.py to exit on Windows
~~Removed URL percent encoding, as it causes my error described in #1~~

Added:

requirements.txt - this file is used in conjunction with pip to install the (missing) requirements faster with pip install -r requirements.txt

raphipod commented 2 years ago

Should be fixed now with the latest commit.

What about the OS naming code? What was it originally supposed to do?

Lecrapouille commented 2 years ago

What about the OS naming code? What was it originally supposed to do?

Sorry I did not get you point ! Where in the script ? For the URL ?

raphipod commented 2 years ago

Line 58-59 in build.py

It errors out on my end (probably because I don't have MinGW installed.) Is that check for MinGW really needed?

Lecrapouille commented 2 years ago

It errors out on my end (probably because I don't have MinGW installed.) Is that check for MinGW really needed?

CEF does not support MinGW. It was an old attempt to compile it. This can be removed

raphipod commented 2 years ago

All right. Thanks for helping! If anything's still wrong, feel free to correct it yourself.

Lecrapouille commented 2 years ago

@raphipod Closed because the package urllib.request seems more promising than wget. But if my new commits do not fix, feel free to create a new one.